jeanclaude
/
DynDns
1
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

👌 IMPROVE: allow specifying the domain to update #2

Manually merged
jeanclaude merged 1 commits from jonas/DynDns:feature/allow-specifying-domain into master 2020-12-19 14:50:48 +01:00
Conversation 1 Commits 1 Files Changed 2 +18 -2
jonas commented 2020-12-19 00:00:19 +01:00
Contributor
Copy Link

this allows DynDNS to be used against Hostpoint accounts with multiple domains
the domain to update is to be configured via the .env variable 'Domain'

this allows DynDNS to be used against Hostpoint accounts with multiple domains the domain to update is to be configured via the .env variable 'Domain'
🚀 1
jeanclaude was assigned by jonas 2020-12-19 00:00:19 +01:00
jeanclaude commented 2020-12-19 09:14:37 +01:00
Owner
Copy Link

I do not have multiple domains to test is, but it looks reasonable to me. I have only added a simgle comment which you may want to consider.

I do not have multiple domains to test is, but it looks reasonable to me. I have only added a simgle comment which you may want to consider.
jeanclaude reviewed 2020-12-19 09:33:44 +01:00
src/HpUpdater.py Outdated
@ -30,0 +32,4 @@
for row in domainTableRows:
if os.environ.get('Domain') == row.find_element_by_class_name('domain-name-value').get_attribute('value'):
row.find_element_by_name('edit_dns').click()
logger.debug('domain found')
jeanclaude commented 2020-12-19 09:10:24 +01:00
Owner
Copy Link

Logging that the domain was found is good, but logging when the domain was not found is probably even more important

Logging that the domain was found is good, but logging when the domain was not found is probably even more important
jonas commented 2020-12-19 09:37:37 +01:00
Author
Contributor
Copy Link

you're right; guess we should log an error in that case and even terminate execution...
let me add that

you're right; guess we should log an error in that case and even terminate execution... let me add that
jeanclaude closed this pull request 2020-12-19 14:50:48 +01:00
jeanclaude closed this pull request 2020-12-19 14:50:48 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
jeanclaude
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jeanclaude/DynDns#2
No description provided.
Delete Branch "jonas/DynDns:feature/allow-specifying-domain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?